Comments on: New code-view feature https://j11y.io/snippets/new-code-view-feature/ Sun, 22 Mar 2015 15:39:22 +0000 hourly 1 https://wordpress.org/?v=5.0.13 By: Simon https://j11y.io/snippets/new-code-view-feature/#comment-757 Wed, 18 Mar 2009 10:45:27 +0000 https://j11y.io/?p=655#comment-757 Awesome idea! And thanks for sharing the code! 🙂

]]>
By: Juno https://j11y.io/snippets/new-code-view-feature/#comment-756 Tue, 17 Mar 2009 02:36:29 +0000 https://j11y.io/?p=655#comment-756 Awesome works James. I suggest add another parameter “url”

codeview.php?url=http://jquery.offput.ca/js/jquery.bgColor.js

what u think?

]]>
By: Rick https://j11y.io/snippets/new-code-view-feature/#comment-755 Sun, 15 Mar 2009 10:19:06 +0000 https://j11y.io/?p=655#comment-755 No problem… it’d only help people like myself who instinctively put a trailing slash on anything that looks like a directory.

]]>
By: James https://j11y.io/snippets/new-code-view-feature/#comment-754 Sun, 15 Mar 2009 08:56:55 +0000 https://j11y.io/?p=655#comment-754 @Rick, thanks for the tip, just changed it. 🙂

]]>
By: Rick https://j11y.io/snippets/new-code-view-feature/#comment-753 Sun, 15 Mar 2009 03:42:57 +0000 https://j11y.io/?p=655#comment-753 Looks great but you might want to change the regexp in the .htaccess file to allow trailing slashes… eg “^(.+.js)/view/?$”

]]>
By: fillform https://j11y.io/snippets/new-code-view-feature/#comment-752 Sat, 14 Mar 2009 23:46:46 +0000 https://j11y.io/?p=655#comment-752 @James Cleaning probably isn’t required, I just do it with every variable I receive. I get so paranoid. 😛

]]>
By: Meshach https://j11y.io/snippets/new-code-view-feature/#comment-751 Sat, 14 Mar 2009 20:35:10 +0000 https://j11y.io/?p=655#comment-751 That is awesome James.

Thanks very much!

]]>
By: James https://j11y.io/snippets/new-code-view-feature/#comment-750 Sat, 14 Mar 2009 19:28:18 +0000 https://j11y.io/?p=655#comment-750 @James, yep, GesHi is awesome! I did consider using something like SyntaxHighlighter or Prettify but I really wanted something server-side plus I’d heard a lot of good things about GeSHi…

@Vasili, In what way does it need cleaning? The contents of the parameter is not echoed or added to a database so I don’t see any security issues.

]]>
By: Vasili https://j11y.io/snippets/new-code-view-feature/#comment-749 Sat, 14 Mar 2009 18:35:16 +0000 https://j11y.io/?p=655#comment-749 I would clean $_GET[‘loc’]. 😉

]]>
By: James https://j11y.io/snippets/new-code-view-feature/#comment-748 Sat, 14 Mar 2009 18:28:51 +0000 https://j11y.io/?p=655#comment-748 Nicely done. GeSHi is a wonder piece of software. I’ve used it before in a similar vein.

]]>